[PATCH] D69184: [libTooling] Introduce general combinator for fixed-value `MatchConsumer`s.

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 18 15:18:40 PDT 2019


gribozavr added a comment.

What are the use cases for non-text values?

I like the name `text` much better... If the name conflict is the issue, I think you could rename it to `toText` -- it would even read more fluently `change(toText("abc"))`, also making it obvious that we are not changing *the text abc*, but we are changing the code to say "abc".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69184/new/

https://reviews.llvm.org/D69184





More information about the cfe-commits mailing list