[PATCH] D69155: [analyzer] Fix off-by-one in operator call parameter binding.

Csaba Dabis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 18 07:04:40 PDT 2019


Charusso accepted this revision.
Charusso marked an inline comment as done.
Charusso added a comment.
This revision is now accepted and ready to land.

I think it will be a great educational material how to touch the core. Good luck!



================
Comment at: clang/lib/StaticAnalyzer/Core/CallEvent.cpp:325
     if (getKind() != CE_CXXAllocator)
       if (isArgumentConstructedDirectly(Idx))
         if (auto AdjIdx = getAdjustedParameterIndex(Idx))
----------------
NoQ wrote:
> Charusso wrote:
> > What about this one? It smells the same issue.
> Here `Idx` is an argument index to begin with, so it shouldn't be a problem.
Okai, thanks!


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69155/new/

https://reviews.llvm.org/D69155





More information about the cfe-commits mailing list