[PATCH] D69122: Add support to find out resource dir and add it as compilation args

Jan Korous via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 17 15:25:09 PDT 2019


jkorous added inline comments.


================
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:70
+    };
+    if (const int RC = llvm::sys::ExecuteAndWait(ClangBinaryPath, PrintResourceDirArgs, {}, Redirects)) {
+      auto ErrorBuf = llvm::MemoryBuffer::getFile(ErrorFile.c_str());
----------------
I haven't looked into this in detail but it feels kind of wasteful to start a process just to get this value. Can't we just expose it in some of the clang libs we already link against?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69122/new/

https://reviews.llvm.org/D69122





More information about the cfe-commits mailing list