[PATCH] D68682: Clang-tidy fix removals removing all non-blank text from a line should remove the line

Conrad Poelman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 17 14:46:46 PDT 2019


poelmanc updated this revision to Diff 225523.
poelmanc edited the summary of this revision.
poelmanc added a comment.

In D68682#1707764 <https://reviews.llvm.org/D68682#1707764>, @alexfh wrote:

> cleanupAroundReplacements is not used by clang-format itself. I believe, it's a part of clang-format only because it was easier to implement it on top of some infrastructure clang-format provides.


Thanks for the correction @alexfh. I've updated the patch to call the line removal from cleanupAroundReplacements().


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68682/new/

https://reviews.llvm.org/D68682

Files:
  clang-tools-extra/clang-tidy/readability/RedundantControlFlowCheck.cpp
  clang-tools-extra/test/clang-tidy/readability-redundant-control-flow.cpp
  clang-tools-extra/test/clang-tidy/readability-redundant-declaration.cpp
  clang-tools-extra/test/clang-tidy/readability-redundant-member-init.cpp
  clang/include/clang/AST/CommentLexer.h
  clang/include/clang/AST/CommentParser.h
  clang/include/clang/Format/Format.h
  clang/lib/AST/CommentLexer.cpp
  clang/lib/AST/CommentParser.cpp
  clang/lib/Format/Format.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68682.225523.patch
Type: text/x-patch
Size: 13149 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191017/806fc040/attachment-0001.bin>


More information about the cfe-commits mailing list