[PATCH] D68410: [AttrDocs] document always_inline

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri requested changes to this revision.
lebedev.ri added a comment.
This revision now requires changes to proceed.

I think partial (but not wrong!) docs is better than no docs whatsoever, so i'd be inclined to proceed with this.
I, too, not really convinced that actual explicit rules should be spelled out.
Some nits, LG otherwise to me.



================
Comment at: clang/include/clang/Basic/AttrDocs.td:4401
+disabled. Does not guarantee that inline substitution actually occurs.
+}];
+  let Heading = "always_inline";
----------------
jdoerfert wrote:
> It is more than that. This would imply that with optimizations enabled there is no effect. I would mention that the inline heuristic is disabled and inlining is always attempted, w/ or w/o optimizations.
This comment wasn't addressed.


================
Comment at: clang/include/clang/Basic/AttrDocs.td:4398
+  let Content = [{
+Inline heuristics are disabled and inlining is always attempted regardless of
+optimization level.
----------------
s/Inline/Inlining/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68410/new/

https://reviews.llvm.org/D68410