[PATCH] D69011: Replace platform-dependent `stat` with `llvm::sys::fs::status`. NFC intended.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 16 01:11:04 PDT 2019


sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

Watching for regressions in stat calls sounds really useful.

This change is trivially equivalent on linux, but the code path is quite different on windows (I have no idea how ::stat works on windows, but our implementation of fs::status does lots of things).
I don't imagine it'll matter here though, and the original commits don't seem to have avoided fs::status on purpose.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69011/new/

https://reviews.llvm.org/D69011





More information about the cfe-commits mailing list