[PATCH] D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics.

Mon Oct 14 13:53:47 PDT 2019

Bigcheese marked an inline comment as done.
Bigcheese added inline comments.

================
Comment at: include/clang/Lex/HeaderSearchOptions.h:209
+  ///
+  /// This includes things like the full header search path.
+  unsigned ModulesStrictHash : 1;
----------------
bruno wrote:
> What else do you plan to add in the future as part of "all the things that could impact"? It seems to me that by default this should always be the case, but header search related things are special because one might want to  handwave on correctness to have smaller caches (default behavior right now). 
> 
> I wonder if we should instead have `fmodules-strict-header-seach` and later on add a more generic thing that group such cases? WDYT?
This also includes diagnostic options. I'm not sure it's useful for users to pick each individual thing they care about for the hash. The intent here is just to capture every possible difference we find.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68528/new/

https://reviews.llvm.org/D68528