[PATCH] D68915: [clang][IFS] Escape mangled name in-order to not break llvm-ifs with names mangled using MS ABI

Puyan Lotfi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 14 11:20:59 PDT 2019


plotfi added a comment.

I see what went wrong. Will post a fix shortly.

In D68915#1708297 <https://reviews.llvm.org/D68915#1708297>, @thakis wrote:

> On macOS symbols are prefixed with an underscore:
>
>   Command Output (stderr):
>   --
>   /Users/thakis/src/llvm-project/clang/test/InterfaceStubs/object.c:5:16: error: CHECK-TAPI: expected string not found in input
>   // CHECK-TAPI: "data" : { Type: Object, Size: 4 }
>                  ^
>   <stdin>:1:1: note: scanning from here
>   --- !experimental-ifs-v1
>   ^
>   <stdin>:6:3: note: possible intended match here
>    "_data" : { Type: Object, Size: 4 }
>     ^
>  
>   --
>   ********************
>   Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
>   Testing Time: 164.94s
>   ********************
>   Failing Tests (1):
>       Clang :: InterfaceStubs/object.c``





Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68915/new/

https://reviews.llvm.org/D68915





More information about the cfe-commits mailing list