[PATCH] D68682: Clang-tidy fix removals removing all non-blank text from a line should remove the line

[Conrad Poelman via Phabricator via cfe-commits]

poelmanc added a comment.

In D68682#1705865 <https://reviews.llvm.org/D68682#1705865>, @Eugene.Zelenko wrote:

> In D68682#1705505 <https://reviews.llvm.org/D68682#1705505>, @jonathanmeier wrote:
>
> > In D68682#1702025 <https://reviews.llvm.org/D68682#1702025>, @poelmanc wrote:
> >
> > > In D68682#1700908 <https://reviews.llvm.org/D68682#1700908>, @Eugene.Zelenko wrote:
> > >
> > > > You may be interested to also look on PR43583 related to readability-redundant-member-init.
> > >
> > >
> > > Thanks Eugene, I'm having trouble finding that. https://reviews.llvm.org/D43583 seems related to MIPS instructions rather than readability-redundant-member-init. Could you please post a link? Thanks.
> >
> >
> > PRs are bug reports. You can access them like this: https://llvm.org/PR43583
>
>
> Or direct link to LLVM Bugzilla (https://bugs.llvm.org/show_bug.cgi?id=<Number>). Ideally Phabricator should recognize PR prefixes in same way as it recognize D.


Thanks @Eugene.Zelenko and @jonathanmeier. https://llvm.org/PR43583 now explains to me perfectly why my initial attempts to remove blank lines solely within readability-redundant-member-init failed: the final removal of ":" that in some cases left the line blank was not made in readability-redundant-member-init but higher up in the cleanup stage.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68682/new/

https://reviews.llvm.org/D68682