[PATCH] D68835: [clang-scan-deps] Add basic support for Clang modules.

[Duncan P. N. Exon Smith via Phabricator via cfe-commits]

dexonsmith added inline comments.


================
Comment at: lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:135
+  return llvm::StringSwitch<bool>(Ext)
+    .CasesLower(".c", ".cc", ".cpp", ".c++", ".cxx", true)
+    .CasesLower(".h", ".hh", ".hpp", ".h++", ".hxx", true)
----------------
arphaman wrote:
> Let me do some experiments to find files in our codebase that have some weird extensions we should minimize as well, to check what else could be there.
I think we should get the standard preprocessed source extensions for completeness, even though it would be rare for someone to send those in. IIRC, `.i`, `.ii`, `.mi`, and `.mmi` (not sure about that last one).


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68835/new/

https://reviews.llvm.org/D68835