[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 10 14:43:17 PDT 2019


nridge added a comment.

Ok, I updated the patch to convey the line highlight separately from the token highlights.

I did use the simplified approach I mentioned, where I use a single `isInactive` flag. If you'd prefer the more general approach where we send an array of line styles, I can do that, though my personal preference would be to wait until we have an actual use case before generalizing.

There are still no tests yet, as I'm still not sure whether we have agreement on the approach. If you like the approach, please let me know, and I'll follow up with tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67536/new/

https://reviews.llvm.org/D67536





More information about the cfe-commits mailing list