[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 9 20:40:26 PDT 2019


nridge added a comment.

Is this what you had in mind?

I'm not seeing where the `kindForType` part comes in. In particular, it seems like it would be silly to call `kindForType` in `WalkUpFromDependentNameTypeLoc()`, because we //know// the answer will be `HighlightingKind::DependentType`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67901/new/

https://reviews.llvm.org/D67901





More information about the cfe-commits mailing list