[PATCH] D68736: [MSVC] Automatically add atlmfc include and lib directories as system paths.

Zachary Turner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 9 15:43:40 PDT 2019


zturner added a comment.

In D68736#1702482 <https://reviews.llvm.org/D68736#1702482>, @amccarth wrote:

> > This matches the behavior of cl.
>
> Are you sure?  In a bare environment, cl.exe doesn't include any system paths, not even to the standard library.  It actually uses the INCLUDE environment variable for those paths.  Granted, VCVARSALL sets that (and other environment variables), but it's not innate behavior of cl.exe.


Right, sorry.  I guess what I mean is that this matches the behavior of running from a cl command prompt, which is what we do elsewhere.  This is already in the codepath that is trying to build up a consistent WindowsSdk + CRT environment, we were just missing the atlmfc part.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68736/new/

https://reviews.llvm.org/D68736





More information about the cfe-commits mailing list