[PATCH] D68715: [mangle] Fix mangling where an extra mangle context is required.

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 9 11:26:59 PDT 2019


efriedma added a comment.

The refactoring of the getCurrentMangleNumberContext API mixed with functional changes makes this much harder to review quickly.  Please separate it out.



================
Comment at: clang/lib/Sema/SemaLambda.cpp:353
+                                          ManglingContextDecl),
+        ManglingContextDecl);
   }
----------------
If I'm following correctly, the core of the change is right here?  Instead of grabbing a context from the ExpressionEvaluationContextRecord directly, we instead grab the current decl from it, and look up the context from that?  That makes sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68715/new/

https://reviews.llvm.org/D68715





More information about the cfe-commits mailing list