[PATCH] D68682: Clang-tidy fixes should avoid creating new blank lines

[MyDeveloperDay via Phabricator via cfe-commits]

MyDeveloperDay added a comment.

Sorry, I'm going to give a drive-by comment (which you can ignore), mainly by because you mentioned `clang-format`.

This seems like a good idea as obviously it solves this problem, however, isn't rather like trying to fix it after the fact?

what if (I'm sure there isn't anything currently doing this so maybe a moot point), someone wrote a clang-tidy checker to say insert newlines between things, sort of imagine something like https://bugs.llvm.org/show_bug.cgi?id=42767 where the person wanted to add missing newlines based on some semantic rule rather than the more traditional way of handling it in clang-format.

This code change kind of says doing anything like replacing something with a newline would be stripped away, to me it feels like this removal of extra white space needs to be handled at the point the replacement is created and not on all the final replacements where the context is lost. (perhaps you already considered that)

Just my 2c worth. but I do think its good to remove the newlines in this case so thank you for that.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68682/new/

https://reviews.llvm.org/D68682