[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Tue Oct 8 05:46:50 PDT 2019

Daniel599 added a comment.

In D68539#1699288 <https://reviews.llvm.org/D68539#1699288>, @MyDeveloperDay wrote:

> > I saw this issue when I submitted mine (https://bugs.llvm.org/show_bug.cgi?id=43306) which for now seems to be a harder fix, still looking for a solution there.
>
> oh boy!...are you gonna have to look at every variable/macro in scope and compare?

Don't know yet, I thought about using  Sema::CheckShadow or Sema::LookupName, but I can't find a Sema instance, not sure how those methods effect performance

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68539/new/

https://reviews.llvm.org/D68539