[PATCH] D68568: [clang-format] Make '.clang-format' variants finding a loop

[MyDeveloperDay via Phabricator via cfe-commits]

MyDeveloperDay added a comment.

Thank you for the patch,

I think this looks cleaner and generally LGTM, I think its always good to put a little description of the change along with the NFC in the title to let people know that functionally there isn't any change without having to work though the code change. Maybe even giving a little rationale as to why you are thinking of making the change.. (which I see from D68569: [clang-format] Also look for .{ext}.clang-format file <https://reviews.llvm.org/D68569>)

As I understand it, you have changed the code to read the configs from a list of file in a loop rather than reading one and then trying another if that cannot be found, subsequently, this would make it relatively easy to add higher priority search options without confusing the code

I think there is some commonality here that could be used with another suggestion which was to allow  --style=<filename> D50147: clang-format: support external styles <https://reviews.llvm.org/D50147>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68568/new/

https://reviews.llvm.org/D68568