[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 4 06:51:47 PDT 2019


MyDeveloperDay added a comment.

@mitchell-stellar I pulled the patch to commit it, but the unit tests fail, could you double-check them for me?

  [       OK ] FormatTest.LayoutBraceInitializersInReturnStatement (13 ms)
  [ RUN      ] FormatTest.LayoutCxx11BraceInitializers
  C:/cygwin64/buildareas/clang/llvm-project/clang/unittests/Format/FormatTest.cpp(70): error:       Expected: Expected.str()
        Which is: "vector< int > x{ };"
  To be equal to: format(Expected, Style)
        Which is: "vector< int > x{};"
  Expected code is not stable
  C:/cygwin64/buildareas/clang/llvm-project/clang/unittests/Format/FormatTest.cpp(72): error:       Expected: Expected.str()
        Which is: "vector< int > x{ };"
  To be equal to: format(Code, Style)
        Which is: "vector< int > x{};"
  C:/cygwin64/buildareas/clang/llvm-project/clang/unittests/Format/FormatTest.cpp(78): error:       Expected: Expected.str()
        Which is: "vector< int > x{ };"
  To be equal to: format(test::messUp(Code), ObjCStyle)
        Which is: "vector< int > x{};"
  [  FAILED  ] FormatTest.LayoutCxx11BraceInitializers (1024 ms)
  [ RUN      ] FormatTest.FormatsBracedListsInColumnLayout


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68415/new/

https://reviews.llvm.org/D68415





More information about the cfe-commits mailing list