[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added inline comments.


================
Comment at: clang-tools-extra/clangd/Compiler.cpp:66
   CI->getLangOpts()->CommentOpts.ParseAllComments = true;
+  CI->getPreprocessorOpts().DetailedRecord = true;
   return CI;
----------------
hokein wrote:
> I'm not sure how does this flag impact the size of Preamble/AST, @ilya-biryukov any thoughts?
Have no idea, but why do we need this in the first place?
`PPCallbacks::SourceRangeSkipped` should allow to record all skipped ranges in the main file. Can we use it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67536/new/

https://reviews.llvm.org/D67536