[PATCH] D68436: [clang-scan-deps] Improve string/character literal skipping

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 3 17:43:13 PDT 2019


arphaman created this revision.
arphaman added reviewers: dexonsmith, Bigcheese, aganea, kousikk.
Herald added subscribers: ributzka, tschuett, jkorous.
Herald added a project: clang.

The existing string/character literal skipping code in the dependency directives source minimizer has two issues:

- It doesn't stop the scanning when a newline is reached before the terminating character, unlike the lexer which considers the token to be done (even if it's invalid) at the end of the line.
- It doesn't support whitespace between '\' and the newline when looking if the '\' is used as a line continuation character.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D68436

Files:
  clang/lib/Lex/DependencyDirectivesSourceMinimizer.cpp
  clang/unittests/Lex/DependencyDirectivesSourceMinimizerTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68436.223125.patch
Type: text/x-patch
Size: 3942 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191004/aed1a793/attachment.bin>


More information about the cfe-commits mailing list