[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added inline comments.


================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:505
+  case HighlightingKind::DependentType:
+    return "entity.name.type.dependent.cpp";
+  case HighlightingKind::DependentName:
----------------
Maybe have a separate category for all dependent entities instead, i.e. use
`entity.name.dependent.type.cpp` and `entity.name.dependent.other.cpp`?

This would allow to specify a single highlighting for both names by stopping at `dependent` subcategory.
I'm not sure how this plays into the default colors provided in the editors that support semantic highlighting...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67901/new/

https://reviews.llvm.org/D67901