[PATCH] D67695: [clangd] Implement getBeginning for overloaded operators.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 1 03:55:08 PDT 2019


hokein added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/SourceCodeTests.cpp:330
+           "/^/ comments", // non-interesting token
+           "void f(int abc) { abc ^ ++; }",    // whitespace
+           "void f(int abc) { ^abc^++; }",     // range of identifier
----------------
ilya-biryukov wrote:
> Do we test `++^^abc` anywhere?
no, but we have a similar test ` ++/**/^abc`, added it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67695/new/

https://reviews.llvm.org/D67695





More information about the cfe-commits mailing list