[PATCH] D68024: [clangd] Implement GetEligiblePoints

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 1 03:42:49 PDT 2019


hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

looks good.



================
Comment at: clang-tools-extra/clangd/unittests/SourceCodeTests.cpp:610
+                       /*FullyQualifiedName=*/const char *,
+                       /*CurrentNamespace*/ const char *>
+      Cases[] = {
----------------
nit: I'd use a struct, it is hard to infer the member by reading `get<0>`,  `get<1>` (I have to go back to the top)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68024/new/

https://reviews.llvm.org/D68024





More information about the cfe-commits mailing list