[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

Tue Oct 1 01:05:11 PDT 2019

ilya-biryukov added a comment.

In D66647#1686021 <https://reviews.llvm.org/D66647#1686021>, @kadircet wrote:

> So currently AST doesn't store any information regarding template parameter locations except the deepest one.
>  Therefore I've changed the availability to discard any methods inside templated classes, since there is no way to
>  validate the template parameter names. Hopefully this should be a rare use-case, and I believe most of the times
>  people have same template paramater names on declaration and definition. Let me know what you think about
>  it.

Thanks! LG, I also think this should be a rare case. The deepest template parameters are typically the only ones anyway.

> In addition to that implemented renaming for function parameters and template parameters in case of templated
>  functions.

Thanks, will take a look!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66647/new/

https://reviews.llvm.org/D66647