[PATCH] D67079: [analyzer] CastValueChecker: Model inheritance

[Artem Dergachev via Phabricator via cfe-commits]

NoQ added a comment.

In D67079#1687577 <https://reviews.llvm.org/D67079#1687577>, @Charusso wrote:

> - `CastVisitor` is the new facility which decides whether the assumptions are appropriate.
> - The math is still WIP.


You need the math to decide whether delaying the decision to a visitor is the right approach.



================
Comment at: clang/test/Analysis/cast-value-hierarchy-fp-suppression.cpp:25-27
+  if (isa<B>(a))
+    if (isa<C>(a))
+      clang_analyzer_warnIfReached(); // no-warning
----------------
Why is `(isa<B>(a) && isa<C>(a))` deemed possible in the first test but not in the second test? o_o


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67079/new/

https://reviews.llvm.org/D67079