[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Sep 29 16:50:08 PDT 2019


thakis added a comment.

If you strongly feel that this is the right direction, go for it, you're code owner here :)

To me, this feels like a regression. This change has no benefit that I can see (at least none that anybody's asked for that I'm aware of – then again I read llvm's bugzilla less than you do), and the drawback that folks have to explicitly pass `/libpath:\path\to\clang\lib\clang\$changing_version\lib\windows` to the linker, which to me is a pretty poor experience. I'd prefer if we used this qualified path for all runtime libs, so that users would never have to use this libpath. (We currently use a qualified path for libprofile but not asan and the like iirc.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65543/new/

https://reviews.llvm.org/D65543





More information about the cfe-commits mailing list