[PATCH] D68148: [clang-tidy] Rename objc-avoid-spinlock check to darwin-avoid-spinlock

Stephane Moore via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Sep 29 16:33:12 PDT 2019


stephanemoore accepted this revision.
stephanemoore added a comment.
This revision is now accepted and ready to land.

I wasn't sure what the policy is for renaming checks so I dug into previous check renames. https://reviews.llvm.org/D43867 seems to indicate that it's acceptable for checks to be renamed with documentation in the release notes (though there is some discussion about the possibility of recognizing the old check name for a grace period). Based on the aforementioned precedent I don't have concerns with this proposed change.

LGTM 👌


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68148/new/

https://reviews.llvm.org/D68148





More information about the cfe-commits mailing list