[PATCH] D68185: [Diagnostics] Warn when class implements a copy constructor/copy assignment operator, but missing the copy assignment operator/copy constructor

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Sep 29 11:04:59 PDT 2019


thakis added a comment.

Since https://en.cppreference.com/w/cpp/language/rule_of_three says "almost always" (note "almost") I'd say this probably belongs more in clang-tidy territory – I'm guessing false positive rate is very high for this. Can you collect some true / false positive statistics on some large open-source project (chromium, firefox, open office, …)?

Since C++11 it's rule of 0/3/5, so this should probably handle the move ctor/assign op too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68185/new/

https://reviews.llvm.org/D68185





More information about the cfe-commits mailing list