[PATCH] D68072: [clang-format] Reference qualifiers in member templates causing extra indentation.

Andreas Wass via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Sep 28 12:48:41 PDT 2019


AndWass marked 4 inline comments as done.
AndWass added inline comments.


================
Comment at: clang/lib/Format/TokenAnnotator.cpp:1375
+    }
+
     // Line.MightBeFunctionDecl can only be true after the parentheses of a
----------------
MyDeveloperDay wrote:
> could this be done using the MatchingParen?
Removed the old code to use `Current.NestingLevel` instead.


================
Comment at: clang/lib/Format/TokenAnnotator.cpp:2704
+    return Style.PointerAlignment != FormatStyle::PAS_Left;
   return true;
 }
----------------
MyDeveloperDay wrote:
>  are you not testing the volatile case? could you add a comment here as to what you are actually matching like the lines above
const and volatile are tested in existing tests. I moved my tests to the same test case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68072/new/

https://reviews.llvm.org/D68072





More information about the cfe-commits mailing list