r373005 - Revert "[analyzer] A speculative attempt to avoid gcc-7 crashes..."

Artem Dergachev via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 26 11:52:00 PDT 2019


Author: dergachev
Date: Thu Sep 26 11:52:00 2019
New Revision: 373005

URL: http://llvm.org/viewvc/llvm-project?rev=373005&view=rev
Log:
Revert "[analyzer] A speculative attempt to avoid gcc-7 crashes..."

This reverts commit r372940 which was an overreaction to a flaky buildbot.

Modified:
    cfe/trunk/lib/StaticAnalyzer/Core/Store.cpp

Modified: cfe/trunk/lib/StaticAnalyzer/Core/Store.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Core/Store.cpp?rev=373005&r1=373004&r2=373005&view=diff
==============================================================================
--- cfe/trunk/lib/StaticAnalyzer/Core/Store.cpp (original)
+++ cfe/trunk/lib/StaticAnalyzer/Core/Store.cpp Thu Sep 26 11:52:00 2019
@@ -51,11 +51,8 @@ StoreRef StoreManager::enterStackFrame(S
   SmallVector<CallEvent::FrameBindingTy, 16> InitialBindings;
   Call.getInitialStackFrameContents(LCtx, InitialBindings);
 
-  for (const auto &I : InitialBindings) {
-    Loc L = I.first.castAs<Loc>();
-    SVal V = I.second;
-    Store = Bind(Store.getStore(), L, V);
-  }
+  for (const auto &I : InitialBindings)
+    Store = Bind(Store.getStore(), I.first.castAs<Loc>(), I.second);
 
   return Store;
 }




More information about the cfe-commits mailing list