[PATCH] D67961: [libTooling] Introduce the MatchConsumer abstraction

[Yitzhak Mandelbaum via Phabricator via cfe-commits]

ymandel marked an inline comment as done.
ymandel added inline comments.


================
Comment at: clang/include/clang/Tooling/Refactoring/MatchConsumer.h:27
+
+/// A central abstraction of the Transformer framework is computation over the
+/// results of a match (represented by \c MatchFinder::MatchResult). We
----------------
gribozavr wrote:
> The comment seems to be a mix of documentation and design justification. How about this?
> 
> ```
> A failable computation over nodes bound by AST matchers.
> 
> It is a central abstraction of the Transformer framework.
> 
> The computation should report any errors though its return value (rather than terminating the program) to enable usage in interactive scenarios like clang-query.
> ```
Much better, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67961/new/

https://reviews.llvm.org/D67961