[PATCH] D67843: DisableFormat also now disables SortIncludes

[MyDeveloperDay via Phabricator via cfe-commits]

MyDeveloperDay added a subscriber: klimek.
MyDeveloperDay added a comment.

I basically agree with all the comments, I agree with you that I doubt its ever used in SortIncludes:true and DisableFormat:true, I just saw this as a hole that probably based on Myrums  Law (https://www.hyrumslaw.com/) means someone somewhere is already using this fact and we could come unstuck.

I have to admit I am surprised that BasedOnStyle:none really turns everything off, I should go back and check that as I've not seen why that is the case (I'm sure you correct)

I also have to admit the project I work on doesn't have a "BasedOnStyle" in our .clang-format, but actually this cause me out when developing a new setting which needed to be true by default (these seemed nowhere for me to set the default)

I think I like the idea of SortIncludes being turned off if not specifically turned on if thats possible, otherwise I'd say this patch LG but I'd check with @klimek as to what he thinks.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67843/new/

https://reviews.llvm.org/D67843