[PATCH] D67916: [clangd] Simplify the callside of URI::resolve, NFC.

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 23 07:10:59 PDT 2019


kadircet requested changes to this revision.
kadircet added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang-tools-extra/clangd/index/BackgroundIndexLoader.cpp:30
+  if (!AbsolutePath) {
+    elog("Failed to resolve URI {0}:", URI, AbsolutePath.takeError());
     return llvm::None;
----------------
kadircet wrote:
> wow, thanks for catching this one.
> 
> `Failed to resolve URI {0}: {1}`
actually can you just inline this into call site?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67916/new/

https://reviews.llvm.org/D67916





More information about the cfe-commits mailing list