[PATCH] D67826: [clangd] A helper to find explicit references and their names

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 23 06:21:50 PDT 2019


kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/FindTarget.h:115
+/// FIXME: extend to report location information about declaration names too.
+void findExplicitReferences(Stmt *S,
+                            llvm::function_ref<void(ReferenceLoc)> Out);
----------------
It might be better to accept a `DynTypedNode` in here as well, so that this can be used with other node types as well, or provide overrides for them(for example `Decl`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67826/new/

https://reviews.llvm.org/D67826





More information about the cfe-commits mailing list