[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

[Puyan Lotfi via Phabricator via cfe-commits]

plotfi marked an inline comment as done.
plotfi added inline comments.


================
Comment at: clang/lib/Driver/Types.cpp:328
+        IfsModePhaseList, std::back_inserter(P), [&DAL](phases::ID Phase) {
+          return Phase <= ((DAL.getLastArg(options::OPT_c)) ? phases::Compile
+                                                            : phases::IfsMerge);
----------------
plotfi wrote:
> compnerd wrote:
> > How does `-c` `-emit-interface-stubs` and multiple input play together?
> Dropped the code for -c. For now, to get the straight up ifs I think -cc1 can be sufficient.
> 
> There are some hairy things regarding getting the correct InputType from Driver::BuildInputs that need to be sorted first. 
I added -c back. Tried this and it works the same as without -emit-interface-stubs

```
$ build/bin/clang -c  -o - -emit-interface-stubs clang/test/InterfaceStubs/weak.cpp clang/test/InterfaceStubs/virtual.cpp 
clang-10: error: cannot specify -o when generating multiple output files
$ build/bin/clang -c  -o -  clang/test/InterfaceStubs/weak.cpp clang/test/InterfaceStubs/virtual.cpp 
clang-10: error: cannot specify -o when generating multiple output files
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63978/new/

https://reviews.llvm.org/D63978