[PATCH] D67897: Fix __is_signed builtin

Arthur O'Dwyer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Sep 22 16:49:15 PDT 2019


Quuxplusone added a comment.

But `std::is_signed_v<float>` needs to yield `false`. Isn't it cleaner to leave the compiler builtin matching the library type-trait, so that the library doesn't have to check for integral types separately?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67897/new/

https://reviews.llvm.org/D67897





More information about the cfe-commits mailing list