[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

Puyan Lotfi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Sep 22 00:01:42 PDT 2019


plotfi marked 7 inline comments as done.
plotfi added inline comments.


================
Comment at: clang/lib/Driver/Types.cpp:328
+        IfsModePhaseList, std::back_inserter(P), [&DAL](phases::ID Phase) {
+          return Phase <= ((DAL.getLastArg(options::OPT_c)) ? phases::Compile
+                                                            : phases::IfsMerge);
----------------
compnerd wrote:
> How does `-c` `-emit-interface-stubs` and multiple input play together?
Dropped the code for -c. For now, to get the straight up ifs I think -cc1 can be sufficient.

There are some hairy things regarding getting the correct InputType from Driver::BuildInputs that need to be sorted first. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63978/new/

https://reviews.llvm.org/D63978





More information about the cfe-commits mailing list