[PATCH] D53768: Add VerboseOutputStream to CompilerInstance

Scott Linder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 20 07:35:22 PDT 2019


scott.linder marked an inline comment as done.
scott.linder added inline comments.


================
Comment at: include/clang/Frontend/CompilerInstance.h:362-363
+  /// If not set, this stream defaults to \c llvm::errs().
+  void setVerboseOutputStream(raw_ostream &Value,
+                              bool OwnsOutputStream = false);
+
----------------
dblaikie wrote:
> Two functions - one that takes a raw_ostream& and another that takes a unique_ptr<raw_ostream>?
Do both overloads transfer ownership? Are the "standard" streams like `llvm::outs()` OK to free?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53768/new/

https://reviews.llvm.org/D53768





More information about the cfe-commits mailing list