[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 17 08:05:31 PDT 2019


aaron.ballman added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp:53
+    CheckFactories.registerCheck<DefaultOperatorNewCheck>(
+        "cert-default-operator-new");
     CheckFactories.registerCheck<performance::MoveConstructorInitCheck>(
----------------
balazske wrote:
> aaron.ballman wrote:
> > balazske wrote:
> > > The checker should be renamed to `cert-mem57-cpp` to comply with the others.
> > Yes, please. It should also be moved under a `// MEM` comment instead of `OOP` (and kept in alphabetical order).
> I will move it, but should I change the order of the commented sections? These are currently not in alphabetic order.
Not for this patch, but that could be done in a separate patch (as an NFC change).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67545/new/

https://reviews.llvm.org/D67545





More information about the cfe-commits mailing list