[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 13 07:22:47 PDT 2019


sammccall added a comment.

Rather than a separate method with parallel implementation, this seems very closely related to the syntax highlighting feature.

The minimal way to model this (no new protocol) would be for each disabled line, to add one token spanning the whole line with a TextMate scope like `comment.disabled` or `meta.disabled`.
There's no technical reason tokens can't overlap in the protocol, though it's possible editors will choose to turn off local heuristic highlighting on anything that's touched by an LSP-provided token.

Failing that, I'd suggest encoding a list of line-styles on `SemanticHighlightingInformation`, that should be combined with any tokens on that line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67536/new/

https://reviews.llvm.org/D67536





More information about the cfe-commits mailing list