[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

Kuan Hsu Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 12 17:24:16 PDT 2019


khchen added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:387
+
+void riscv::addGoldOptions(const ToolChain &ToolChain,
+                           const llvm::opt::ArgList &Args,
----------------
kito-cheng wrote:
> MaskRay wrote:
> > gold doesn't support RISC-V, does it?
> Gold doesn't support RISC-V , but ld.bfd supported same plugin API, so this made clang can run LTO with ld.bfd.
I reference `AddGoldPlugin` to naming this function, is it confusing?



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67409/new/

https://reviews.llvm.org/D67409





More information about the cfe-commits mailing list