[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 11 11:35:48 PDT 2019


NoQ added a comment.

In D67420#1666141 <https://reviews.llvm.org/D67420#1666141>, @Szelethus wrote:

> - For these select 4 options that suffer compatibility issues, manually check `AnalyzerOptions::ConfigTable`.


*3 options. `ToolInvocation` is not really an option that you're ever supposed to adjust manually. Which is one more reason for me to think of this structure as of an implementation detail - an interface through which diagnostic consumers' behavior can be tweaked, regardless of why the tool wants it to be tweaked (because the human told it to or because the tool itself knows better).


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67420/new/

https://reviews.llvm.org/D67420





More information about the cfe-commits mailing list