[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

Wed Sep 11 09:04:46 PDT 2019

paulkirth added a comment.

In D66324#1665784 <https://reviews.llvm.org/D66324#1665784>, @lebedev.ri wrote:

> In D66324#1665773 <https://reviews.llvm.org/D66324#1665773>, @gribozavr wrote:
>
> > Reverted in r371598.
> >
> > Another concern that I have is cross-compilation. LLVM's ADT is not set up to be cross-compiled like the rest of compiler-rt is.
>
>
> Uhm, i have a better question still - why xxhash is even there? it's not used in the diff, and was not reviewed, it just magically appeared in the last update of the patch:
>  https://reviews.llvm.org/D66324?vs=219617&id=219645

It shouldn't have. My last change only modified a test file to not trigger a memory corruption bug. I'm filing a bug for that, but am waiting on a login for the bug tracker.

What I suspect happened is that when this landed some local changes got sucked in. I'm terribly sorry, it wasn't my intention to add anything significant to the patch.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66324/new/

https://reviews.llvm.org/D66324