[PATCH] D67419: [analyzer] NFC: Move PathDiagnostic to libAnalysis.

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 11 05:19:50 PDT 2019


Szelethus added a comment.

Looks great! Are we sure that `PathDiagnostic.h` is a good header name?



================
Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:26
 #include "clang/ASTMatchers/ASTMatchFinder.h"
-#include "clang/Config/config.h"
 #include "clang/Format/Format.h"
----------------
NoQ wrote:
> This needed to go up because that's where `CLANG_ENABLE_STATIC_ANALYZER` is defined.
Let's add some scary comments then, to warn everyone trying to blindly clang-format this file.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67419/new/

https://reviews.llvm.org/D67419





More information about the cfe-commits mailing list