[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 11 02:25:15 PDT 2019


lebedev.ri added a comment.

In D66324#1665773 <https://reviews.llvm.org/D66324#1665773>, @gribozavr wrote:

> Reverted in r371598.
>
> Another concern that I have is cross-compilation. LLVM's ADT is not set up to be cross-compiled like the rest of compiler-rt is.


Uhm, i have a better question still - why xxhash is even there? it's not used in the diff, and was not reviewed, it ajust magically appeared in the last update of the patch:
https://reviews.llvm.org/D66324?vs=219617&id=219645


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66324/new/

https://reviews.llvm.org/D66324





More information about the cfe-commits mailing list