[PATCH] D67135: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 11 01:12:32 PDT 2019


hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

thanks, looks good.



================
Comment at: clang-tools-extra/test/clang-tidy/performance-inefficient-vector-operation.cpp:315
+    foo.mutable_x();
+    // CHECK-FIXES-NOT: foo.mutable_x->Reserve(5);
+    for (int i = 0; i < 5; i++) {
----------------
looks like we miss `()`, the same below.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67135/new/

https://reviews.llvm.org/D67135





More information about the cfe-commits mailing list