[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

Thu Sep 5 16:13:23 PDT 2019

aheejin added a comment.

In D67208#1659941 <https://reviews.llvm.org/D67208#1659941>, @sbc100 wrote:

> But why not make -mexception-handling  be the option that enabled everything?  I mean -mexception-handling is a flag we have today..  if you add -fwasm-exceptions what does -mexception-handling meaning?  Is it still useful?

As I said above, I'm not sure making architecture flags control everything is a good idea. I view those flags as very low-level flags whose only job is exactly turn on those architecture features (Others may view them differently though). Likewise, currently setting `--pthreads` controls other features, but setting `-matomics` or `-mbulk-memory` does not control other features.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67208/new/

https://reviews.llvm.org/D67208