[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 5 15:51:23 PDT 2019


Szelethus added a comment.

In D67140#1659907 <https://reviews.llvm.org/D67140#1659907>, @NoQ wrote:

> In D67140#1659872 <https://reviews.llvm.org/D67140#1659872>, @aaron.ballman wrote:
>
> > If we're okay with the inconsistency but still feel like giving ourselves more work, adding proper punctuation to Static Analyzer diagnostics would at least make them grammatically correct. :-D
>
>
> I'd love us some punctuation! Unfortunately the last time a person who actually speaks English committed actively to the Static Analyzer was, like, a couple of years ago at least (:


I guess there's a joke waiting to be made about a couple Hungarians and Russians discussing how to write proper English :^) With that said, we could ask @whisperity to chip in more, he has an ever-growing academic background, and a keen eye for grammatical errors.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67140/new/

https://reviews.llvm.org/D67140





More information about the cfe-commits mailing list