[PATCH] D67028: Use musttail for variadic method thunks when possible

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 5 15:29:19 PDT 2019


rnk added a comment.

In D67028#1659881 <https://reviews.llvm.org/D67028#1659881>, @efriedma wrote:

> > In your test case, we hit the early return that I linked to, so we don't try to clone, and we don't need to emit an error.
>
> Yes, that's what happens with the Itanium ABI; what happens with the MS ABI?


I see, it doesn't work. There's also the case of the MS ABI for ISAs that don't support musttail, although that's less interesting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67028/new/

https://reviews.llvm.org/D67028





More information about the cfe-commits mailing list