[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

Heejin Ahn via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 5 15:28:05 PDT 2019


aheejin added a comment.

@tlively @sbc100 What I wanted was to make `-fwasm-exceptions` as something like `-pthreads`, which serves as the only flag that needs to be turned on and turns on all other necessary flags, such as `+matomics`, `+mbulk-memory`, and `--shared-memory`. I think all those architectural flags starting with `-m` can be someday all turned on, when all our existing proposals become the new MVP, and I still want to give users an option to opt out of threads of exception handling at that point. And it also makes sense to have a `LangOption` of `WasmExceptions` given that there are `LangOption`s for all other exception models. I think this covers most of the questions above.

@tlively

> Is there a plan to turn this on by default at some point, or will users always have to opt-in to using exceptions?

I'm planning to create an emscripten option, something like `-s EXCEPTION_HANDLING=1`, to turn this option on. Maybe at some point, when we don't use emscripten exception anymore and all wasm platforms (wasi and emscripten and what not) use the new exception proposal, we can consider turning this on by default. Until then I incline not to.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67208/new/

https://reviews.llvm.org/D67208





More information about the cfe-commits mailing list